feat(Biz): Add helper functions to support `BizPasskeySessionAccount` by satoshiotomakan · Pull Request #4516 · trustwallet/wallet-core

satoshiotomakan · 2025-10-01T16:34:35Z

This pull request adds support for Passkey Session operations in the Barz module, enabling registration, removal, nonce encoding, and batch execution of transactions using passkey sessions. It introduces new ABI encoding functions, FFI bindings, and comprehensive tests to ensure correct behavior.

Passkey Session ABI and Encoding Support

Added BizPasskeySessionAccount struct in biz_passkey_session.rs with methods for registering, removing, and executing with passkey sessions, including ABI encoding logic for these operations.
Implemented helper functions in barz/core.rs for encoding register, remove, nonce, and batch execution calls for passkey sessions, with error handling for invalid public keys and nonce values. [1] [2]

FFI Bindings

Add Biz module
- BREAKING Move Barz.getEncodedHash to Biz.getEncodedHash
- BREAKING Move Barz.getSignedHash to Biz.getSignedHash
- Add Biz.encodeRegisterSessionCall
- Add Biz.encodeRemoveSessionCall
- Add Biz.encodePasskeySessionNonce
- Add Biz.encodeExecuteWithPasskeySessionCall
Add Eip7702 module
- BREAKING Move Barz.getAuthorizationHash to Eip7702.getAuthorizationHash
- BREAKING Move Barz.signAuthorization to Eip7702.signAuthorization
Add WebAuthnSolidity module with the following methods:
- WebAuthnSolidity.getMessageHash
- WebAuthnSolidity.GetFormattedSignature

Testing and Validation

Added extensive tests in barz_ffi.rs to validate passkey session registration, removal, nonce encoding, and batch execution, ensuring ABI outputs match expected values.

Refactoring and Internal Improvements

Refactored batch encoding logic in biz.rs to use a dedicated function for array token conversion, improving code clarity and reuse. [1] [2] [3] [4]
Updated module imports and error definitions to support new functionality and error cases. [1] [2] [3] [4]

10gic · 2025-10-02T02:52:15Z

rust/tw_evm/src/ffi/eip7702.rs

+/// \return The signed authorization.
+#[tw_ffi(ty = static_function, class = TWEip7702, name = SignAuthorization)]
+#[no_mangle]
+pub unsafe extern "C" fn tw_eip7702_sign_authorization(


Does the Ethereum message signature functionality meet your needs?

Refers:

wallet-core/src/proto/Ethereum.proto

Line 318 in 6d1a0ed

MessageType_eip7702_authorization = 5;

wallet-core/rust/tw_evm/tests/message_signer.rs

Line 320 in 6d1a0ed

fn test_message_signer_sign_eip7702_authorization() {

Hi @10gic, I think it does, but our client app depends on the function already, I want to leave it as is for now. But let me mark as deprecated

…Signature`

* Rename `TWWebAuthn` module to `TWWebAuthnSolidity`

github-actions · 2025-10-02T17:40:06Z

Binary size comparison

➡️ aarch64-apple-ios:

- 14.11 MB
+ 14.15 MB 	 +50 KB

➡️ aarch64-apple-ios-sim:

- 14.11 MB
+ 14.16 MB 	 +50 KB

➡️ aarch64-linux-android:

- 18.57 MB
+ 18.64 MB 	 +72 KB

➡️ armv7-linux-androideabi:

- 15.53 MB
+ 15.59 MB 	 +60 KB

➡️ wasm32-unknown-emscripten:

- 13.23 MB
+ 13.29 MB 	 +54 KB

gupnik

Looks great @satoshiotomakan! Just asked for one minor clarification.

gupnik · 2025-10-03T05:07:23Z

rust/tw_evm/src/ffi/biz.rs

+
+/// Encodes `Biz.removeSession` function call to deregister a session passkey public key.
+///
+/// \param session_passkey_public_key The nist256p1 (aka secp256p1) public key of the session passkey.


Do we support both nist and secp here?

nist256p1 and secp256p1 are names of the same elliptic curve, however "official" and more recognized name is secp256p1. In WalletCore, we inherited this name from C++ TWCurve enum and TrezorCrypto, and we continue naming it like that.

Interesting. I thought both are ECDSA but have different params, which made us have two separate implementations.

https://github.com/trustwallet/wallet-core/blob/master/rust/tw_keypair/src/ecdsa/secp256k1/keypair.rs
https://github.com/trustwallet/wallet-core/blob/master/rust/tw_keypair/src/ecdsa/nist256p1/keypair.rs

gupnik · 2025-10-03T05:10:59Z

rust/tw_evm/tests/biz.rs

+        "0x49960de5880e8c687434170f6476605b8fe4aeb9a28632c7995cf3ba831d97630500000000";
+    let client_data_json = r#"{"type":"webauthn.get","challenge":"fRMDMfFrs9K8PXLbAoedB0XURSWS5Wcj3osnzx7gBsc","origin":"https://sign.coinbase.com","crossOrigin":false}"#;
+
+    // secp256p1 (nist256p1) private key.


gupnik · 2025-10-03T05:11:23Z

rust/tw_evm/src/ffi/webauthn_solidity.rs

+use tw_memory::ffi::{Nonnull, NullableMut, RawPtrTrait};
+use tw_misc::try_or_else;
+
+/// Computes WebAuthn message hash to be signed with secp256p1 private key.


It says secp here though.

* fiux(ci): Use `iPhone 16` in ios-release (#4493) * Throw exception rather than SIGSEGV (#4443) * Throw exception rather than SIGSEGV * Fix test cases * Add NULL checker for exceptionClass * feat(Plasma): Add Plasma Mainnet (#4499) * feat(plasma): Add Plasma Mainnet * feat(plasma): Add mobile tests * [Solana]: Adds ability to transfer tokens to the feepayer (#4503) * Initial setup * Minor updates * Restructure * fix(barz): Replace u32 parameters with i32 (#4504) * Disallow to use unsigned integer parameters within class methods * fix(data): Allocate empty array on `tw_data_create_with_bytes` if data is NULL (#4508) * fix(data): Allocate empty array on `tw_data_create_with_bytes` if data is NULL * fix(data): Add TWData test * feat(Biz): Add helper functions to support `BizPasskeySessionAccount` (#4516) * feat(biz-passkey): Add `TWBarzEncodeRegisterSessionCall` FFI * feat(biz-passkey): Add `TWBarzEncodeRemoveSessionCall` FFI * feat(biz-passkey): Add `TWBarzEncodePasskeySessionNonce` FFI * feat(biz-passkey): Add `TWBarzEncodeExecuteWithPasskeySessionCall` FFI * refactor(barz): Move some functions to TWBiz and TWEip7702 modules * feat(biz): Add WebAuthn * feat(biz): Add `TWWebAuthnGetMessageHash` and `TWWebAuthnGetFormattedSignature` * feat(biz): Fix C++ and Mobile * Rename `TWWebAuthn` module to `TWWebAuthnSolidity` * feat(biz): Adjust `executeWithPasskeySession` arguments * feat(biz): Fix fmt * feat(biz): Add Biz Android tests * feat(biz): Add final Biz Android test * feat(biz): Fix lints * feat(biz): Minor change * feat(biz): fmt * feat(solana): Add `SolanaTransaction.insertTransferInstruction()` (#4523) * feat(solana): Add `transfer_to_fee_payer` instruction * feat(solana): Add `tw_solana_transaction_insert_transfer_instruction` FFI * feat(solana): Add a note comment * feat(solana): Add one more comment * feat(zcash): Add support for TEX address (#4527) * feat(zcash): Add `TexAddress` in Rust * feat(zcash): Add successfully broadcasted transaction test * feat(zcash): Add successfully broadcasted transaction C++ test * feat(zcash): Fix C++ tests * feat(zcash): Reuse code in `TexAddress::isValid` * feat(zcash): Fix `TexAddress:isValid` * [Solana]: Renames fee recipient token account for clarity (#4528) * [Solana]: Renames fee recipient token account for clarity * Fix typo * Feature: Add trade and secured fields to THORChain Asset (#4500) * my tracked commit * MsgInstantiateContract * revert formatting * test * Tests fixes and broadcast * cargo fmt * remove unused * feat: add trade and secured fields to Thorchain Asset - Add trade and secured boolean fields to Asset proto message - Update ThorchainAsset struct in Rust with new fields - Update asset initialization in tx_builder.rs - Matches Thorchain blockchain Asset struct definition --------- Co-authored-by: gupnik <mail.guptanikhil@gmail.com> * feat(kusama-asset-hub): Add ability to force to use `ChargeAssetTxPayment` (#4541) * feat(kusama-asset-hub): Add ability to force to use `ChargeAssetTxPayment` for native tip * feat(kusama-asset-hub): Add a unit test * feat(monad): Add Monad testnet (#4543) * feat(monad): Update Monad to mainnet (#4550) * TODO update explorer * feat(monad): Update block explorer (#4553) * feat(monad): Update explorer * feat(monad): Update explorer schema * Fix incorrect value of NO_PAD constant (#4487) Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com> * fix(public-key): Fix `PublicKey::verify` by adding signature length validation (#4565) * fix(public-key): Fix `PublicKey::verify` by adding signature length validation * fix(public-key): Fix PR comments * Fix Reveal Operations for Seoul Protocol (#4557) * Since the Seoul protocol, reveal operations require the presence of a boolean for whether or not the proof field is present. This is required when manually forging bytes. Added. * Fix TezosTests.swift * Fix TezosTests.swift * Update tests * Update tests * Fix TezosCompiler.CompileWithSignatures * Fix TezosCompiler.CompileWithSignatures * fix(tezos): Fix Tezos compile test * fix(tezos): Fix Tezos signing test * fix(tezos): Add mainnet test transaction --------- Co-authored-by: gupnik <nikhil.g@trustwallet.com> Co-authored-by: Sergei Boiko <satoshiotomakan8@gmail.com> * fix(public-key): Check zilliqa schnorr signature size (#4571) * fix(public-key): Check zilliqa schnorr signature size * Replace assert macros with proper checks * fix(public-key): Address a PR comment * fix(public-key): Address a PR comments * fix(public-key): Fix a bug in PublicKey constructor * feat(pczt): Add implementation of PCZT signing (#4576) * feat(pczt): Add implementation of PCZT signing * feat(pczt): Add a successfully broadcasted tx test * feat(pczt): Address PR comments * fix(webauthn): Fix buffer out of bounds (#4577) * fix(webauthn): Fix buffer out of bounds * fix(webauthn): Fix `TWWebAuthnGetRSValues` implicit Data conversion * fix(webauthn): Extra checks for algorithm, and public key parts * fix(webauthn): Test common buffer overflows * fix(webauthn): Check `crv` and `kty` parameters * fix(private-key): Add PrivateKey Data move constructor * chore(noexcept): Remove wrong noexcept * fix(private-key): Zeroize memory on move `operator=` * fix(private-key): Avoid cleaning private key if self-assign * fix(aes): Add iv size validation (#4580) * fix(aes): Add iv size validation * fix(aes): Add unit tests * Update Dockerfile to install cbindgen with --locked and provide explicit links to clang binaries (#4568) * install cbindgen with --locked * add explicit links to clang/clang++ since CMake will not use the ENV --------- Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com> * feat(stable-account): Add `TWDerivationSmartChainStableAccount` derivation type (#4585) * fix(overflow): Fix integer overflows in `BinaryEncoding` and `Pactus` (#4592) * fix(binary-coding): Avoid unsigned integer overflow * fix(pactus): Avoid unsigned integer overflow * feat(tron): Add `raw_data_hex` parameter in JSON transaction representation (#4593) * feat(tron): Add `raw_data_hex` parameter in JSON transaction representation * feat(tron): Fix iOS test * feat(biz): Add `Biz.signExecuteWithSignatureCall` and `BizPasskeySession.signExecuteWithSignatureCall` (#4594) * feat(biz): Add `Biz.SignExecuteWithSignatureCall` * Add new `BizPasskeySession` module * feat(biz): Add `Biz.SignExecuteWithSignatureCall` * Finish `BizPasskeySession` module separation * feat(biz): Fix android tests * feat(biz): Address PR review comments * chore(codeowners): Add onchain-corex-enabling team to CODEOWNERS (#4600) * fix(ethereum-abi): Fix Ethereum ABI type parsing recursion + chore actions and toolchain (#4597) * fix(ethereum-abi): Fix Ethereum ABI type parsing recursion * fix(ethereum-abi): Freeze community github actions * chore(rust): Bump rust toolchain version to nightly-2025-12-11 * chore(wasm): Try to update emsdk to 4.0.22 * chore(rust): Decrease code coverage to 94.1 due to a recent toolchain update * chore(rust): Freeze `actions` hashes --------- Co-authored-by: Sergei Boiko <satoshiotomakan8@gmail.com> Co-authored-by: Sergei <> * chore(actions): Replace unverified actions with GH scripts (#4604) * chore(actions): Replace unverified actions with GH scripts * chore(actions): Update rust toolchain in Dockerfile * fix(bitcoin-v2): Fail if `max_amount_output` provided with `outputs` or `change_output` at a time (#4607) * fix(bitcoin-v2): Fail if `max_amount_output` provided with `outputs` or `change_output` at a time * fix(bitcoin-v2): PR notes * fix(cbor): Fix Cbor Map with odd elements number decoding (#4610) * fix(cbor): Fix Cbor Map with odd elements number decoding * fix(cbor): Change test name * chore(sync): Fix merge conflicts Breaking changes: * The following FFIs take i32 instead of u32 due to Kotlin bindings limitations: `tw_hd_node_create_with_seed`, `tw_hd_node_create_with_extended_private_key`, `tw_hd_node_derive_from_path`, `tw_hd_node_extended_private_key`, `tw_hd_node_extended_public_key`, `tw_hd_node_public_create_with_extended_public_key`, `tw_hd_node_public_derive_from_path`, `tw_mnemonic_generate`, `tw_mnemonic_get_word`, `tw_pbkdf2_hmac_sha512`, `tw_ecdsa_pubkey_hash` * `crypto_scrypt` FFI is no longer marked as `tw_ffi` to avoid changing u32 and usize argument types to i32 * chore(sync): Increase test coverage * Add Bitcoin PSBT compile test * Add `PrivateKey.CopyAssignmentOperator` and `PrivateKey.MoveAssignmentOperator` tests * Copy Rust TWMnemonic tests to C++ * Copy Rust Biz tests to C++ * Copy Rust BizPasskeySession tests to C++ * chore(sync): Push missing PSBT implementation + remove unused code * chore(sync): Fix Biz android tests --------- Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com> Co-authored-by: 10gic <github10gic@proton.me> Co-authored-by: gupnik <nikhil.g@trustwallet.com> Co-authored-by: Enrique Souza <enriquesouza@live.com> Co-authored-by: gupnik <mail.guptanikhil@gmail.com> Co-authored-by: Corey Soreff <csoreff@gmail.com> Co-authored-by: Sergei Boiko <satoshiotomakan8@gmail.com> Co-authored-by: Joey Yandle <xoloki@gmail.com>

…trustwallet#4516) * feat(biz-passkey): Add `TWBarzEncodeRegisterSessionCall` FFI * feat(biz-passkey): Add `TWBarzEncodeRemoveSessionCall` FFI * feat(biz-passkey): Add `TWBarzEncodePasskeySessionNonce` FFI * feat(biz-passkey): Add `TWBarzEncodeExecuteWithPasskeySessionCall` FFI * refactor(barz): Move some functions to TWBiz and TWEip7702 modules * feat(biz): Add WebAuthn * feat(biz): Add `TWWebAuthnGetMessageHash` and `TWWebAuthnGetFormattedSignature` * feat(biz): Fix C++ and Mobile * Rename `TWWebAuthn` module to `TWWebAuthnSolidity` * feat(biz): Adjust `executeWithPasskeySession` arguments * feat(biz): Fix fmt * feat(biz): Add Biz Android tests * feat(biz): Add final Biz Android test * feat(biz): Fix lints * feat(biz): Minor change * feat(biz): fmt

satoshiotomakan added 5 commits October 1, 2025 13:44

feat(biz-passkey): Add TWBarzEncodeRegisterSessionCall FFI

e325695

feat(biz-passkey): Add TWBarzEncodeRemoveSessionCall FFI

d6bcbd2

feat(biz-passkey): Add TWBarzEncodePasskeySessionNonce FFI

40b35c7

feat(biz-passkey): Add TWBarzEncodeExecuteWithPasskeySessionCall FFI

05f2b27

refactor(barz): Move some functions to TWBiz and TWEip7702 modules

8913ebb

10gic reviewed Oct 2, 2025

View reviewed changes

satoshiotomakan added 3 commits October 2, 2025 13:03

feat(biz): Add WebAuthn

659afd3

feat(biz): Add TWWebAuthnGetMessageHash and `TWWebAuthnGetFormatted…

5d12232

…Signature`

feat(biz): Fix C++ and Mobile

cd7ac5d

* Rename `TWWebAuthn` module to `TWWebAuthnSolidity`

satoshiotomakan marked this pull request as ready for review October 2, 2025 17:06

satoshiotomakan requested a review from gupnik as a code owner October 2, 2025 17:06

satoshiotomakan added 2 commits October 2, 2025 19:26

feat(biz): Adjust executeWithPasskeySession arguments

4f9482f

feat(biz): Fix fmt

21adeb6

satoshiotomakan added 5 commits October 2, 2025 19:41

feat(biz): Add Biz Android tests

ba5b07c

feat(biz): Add final Biz Android test

3401ac9

feat(biz): Fix lints

b1d3f8f

feat(biz): Minor change

da31ec7

feat(biz): fmt

9ac79e4

gupnik approved these changes Oct 3, 2025

View reviewed changes

satoshiotomakan merged commit 5198377 into master Oct 3, 2025
15 of 16 checks passed

satoshiotomakan deleted the feat/barz-passkey branch October 3, 2025 07:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Biz): Add helper functions to support `BizPasskeySessionAccount`#4516

feat(Biz): Add helper functions to support `BizPasskeySessionAccount`#4516
satoshiotomakan merged 15 commits intomasterfrom
feat/barz-passkey

satoshiotomakan commented Oct 1, 2025 •

edited

Loading

Uh oh!

10gic Oct 2, 2025

Uh oh!

satoshiotomakan Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

gupnik left a comment

Uh oh!

gupnik Oct 3, 2025

Uh oh!

satoshiotomakan Oct 3, 2025

Uh oh!

gupnik Oct 3, 2025

Uh oh!

gupnik Oct 3, 2025

Uh oh!

gupnik Oct 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

satoshiotomakan commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passkey Session ABI and Encoding Support

FFI Bindings

Testing and Validation

Refactoring and Internal Improvements

Uh oh!

10gic Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

satoshiotomakan Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary size comparison

Uh oh!

gupnik left a comment

Choose a reason for hiding this comment

Uh oh!

gupnik Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

satoshiotomakan Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gupnik Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gupnik Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gupnik Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

satoshiotomakan commented Oct 1, 2025 •

edited

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading