fix(MMIOBridge): modify TIMERRange from fix value to soc parameter#453
Merged
good-circle merged 4 commits intomasterfrom Dec 18, 2025
Merged
fix(MMIOBridge): modify TIMERRange from fix value to soc parameter#453good-circle merged 4 commits intomasterfrom
good-circle merged 4 commits intomasterfrom
Conversation
zhaohong1988
requested review from
Ivyfeather,
Kumonda221-CrO3 and
linjuanZ
as code owners
good-circle
requested changes
Dec 16, 2025
Contributor
Author
|
Yes, in fact, This is finally provided from soc parameter TIMERRange, which is showed in L2Top.scala, if coded correctly ～
来自钉钉专属商务邮箱------------------------------------------------------------------
发件人：Haoyuan ***@***.***>
日 期：2025年12月16日 19:44:28
***@***.***>
***@***.***>; ***@***.***>
主 题：Re: [OpenXiangShan/CoupledL2] fix(MMIOBridge): modify TIMERRange from fix value to soc parameter (PR #453)
@good-circle requested changes on this pull request.
In src/main/scala/coupledL2/L2Param.scala:
@@ -132,7 +132,8 @@ case class L2Param(
hasSramCtl: Boolean = false,
// Enable new clint
- EnablePrivateClint: Boolean = false
+ EnablePrivateClint: Boolean = false,
+ PrivateClintRange: AddressSet = AddressSet(0x38000000L, 0xFFFF)
Do PrivateClintRange here and TIMERRange in the YML file need to be manually kept the same? Is there a better way to ensure that the two remain consistent?
If it cannot be ensured automatically, please add comments in both places to let other developers know that they must keep these two ranges consistent.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
zhaohong1988
force-pushed
the
coupledL2_privateclint_fix
branch
from
e18471e to
8994331
Compare
good-circle
approved these changes
Dec 18, 2025
linjuanZ
reviewed
Dec 18, 2025
zhaohong1988
force-pushed
the
coupledL2_privateclint_fix
branch
from
2c663d5 to
f65a8ec
Compare
linjuanZ
approved these changes
Dec 18, 2025
yu-yake2002
added a commit
to OpenXiangShan/HBL2
that referenced
this pull request
Mar 6, 2026
Merge coupledL2 commits from 95e8de to 727a04c (xs/master), which is the latest on xs/master as of Mar 5, 2026. Squashed commit of the following: commit 62195c6 Author: zhanglinjuan <zhanglinjuan16@mails.ucas.ac.cn> Date: Mon Dec 01 17:59:00 2025 +0800 timing(MainPipe): fix critical path from Dir error to GrantBuffer (OpenXiangShan#448) commit fffb491 Author: Ding Haonan <kumonda@kucro3.org> Date: Thu Dec 04 11:36:48 2025 +0800 timing(TL2CHICoupledL2): 2-stage cap P-Credit Queue (OpenXiangShan#449) commit f118bca Author: Yanqin Li <maxpicca@qq.com> Date: Tue Dec 16 21:26:05 2025 +0800 refactor: refine prefetch statistics in topdown monitor (OpenXiangShan#452) commit b40da89 Author: Ma-YX <71326427+Ma-YX@users.noreply.github.com> Date: Wed Dec 17 18:58:51 2025 +0800 fix(TXDAT): fix wrong DataCheck generation when data invalid (OpenXiangShan#455) commit e4fd161 Author: Ma-YX <71326427+Ma-YX@users.noreply.github.com> Date: Wed Dec 17 21:36:01 2025 +0800 fix(CoupledL2): fix l2MissMatch io compilation error (OpenXiangShan#456) commit 4e4a6aa Author: Kunlin You <youkunlin20@mails.ucas.ac.cn> Date: Thu Dec 18 19:13:20 2025 +0800 feat(clockGate): support disable ClockGate with parameters (OpenXiangShan#451) commit feacfb5 Author: zhaohong1988 <156632870+zhaohong1988@users.noreply.github.com> Date: Fri Dec 19 00:24:20 2025 +0800 fix(MMIOBridge): modify TIMERRange from fix value to soc parameter (OpenXiangShan#453) commit c5ad8f4 Author: Yanqin Li <maxpicca@qq.com> Date: Fri Dec 19 00:24:53 2025 +0800 ci: add submodule check and remove the dependency of utility in OpenLLC (OpenXiangShan#454) commit ea0c313 Author: Ding Haonan <kumonda@kucro3.org> Date: Fri Dec 26 09:41:32 2025 +0800 fix(MMIOBridge): remove redundant BEU range exclusion in L2 (OpenXiangShan#457) commit f292774 Author: Ding Haonan <kumonda@kucro3.org> Date: Thu Jan 08 10:15:15 2026 +0800 fix(Opcode): missing SnpPreferUniqueFwd in SnpXFwd (OpenXiangShan#460) commit 59f3025 Author: Ma-YX <71326427+Ma-YX@users.noreply.github.com> Date: Wed Jan 14 15:59:43 2026 +0800 fix(MainPipe): fix l2Error_s3 generation logic (OpenXiangShan#463) commit 3c9525f Author: Haoyuan Feng <fenghaoyuan19@mails.ucas.ac.cn> Date: Mon Feb 02 10:17:49 2026 +0800 fix(ClockGate): fix bug that ICG is invalid when disable mbist (OpenXiangShan#470) commit 0d20557 Author: yulightenyu <145419941+yulightenyu@users.noreply.github.com> Date: Tue Mar 03 14:26:16 2026 +0800 fix(AsyncBridge): restore performance considering async depth is 4 (OpenXiangShan#472) commit ef2deb5 Author: Ding Haonan <kumonda@kucro3.org> Date: Wed Mar 04 16:20:19 2026 +0800 fix(MSHR): hold LikelyShared on retried writes (OpenXiangShan#474) commit 727a04c Author: Haoyuan Feng <fenghaoyuan19@mails.ucas.ac.cn> Date: Wed Mar 04 17:01:33 2026 +0800 feat(mmioBridge): increase mmioBridgeSize to 16 for better NC perf (OpenXiangShan#475)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the source of parameter EnablePrivateClint to soc parameter UsePrivateClint