Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version by JamesBurnside · Pull Request #2428 · Azure/communication-ui-library

JamesBurnside · 2022-10-21T17:49:37Z

What

Update html-to-parser version to the latest version that supports react 18
Add documentation for minimum typescript and webpack support
Update storybook manager to use webpack 5 (to avoid Failed to Compile, with this error. fb55/htmlparser2#1237)
Update tools/check-treeshaking to use babel workaround for: Failed to Compile, with this error. fb55/htmlparser2#1237

Why

Continuation of #2415 and #2427 to support react 18.

How Tested

Verified storybook ran locally.

github-actions · 2022-10-21T17:55:40Z

Storybook URL https://60c7ae6891f0e90039d7cd54-touvlhyebj.chromatic.com/

github-actions · 2022-10-21T17:56:14Z

CallWithChat bundle size is decreased✅.

Current size: 5652005
Base size: 5725729
Diff size: -73724

github-actions · 2022-10-21T17:56:17Z

Calling bundle size is decreased✅.

Current size: 5264705
Base size: 5338429
Diff size: -73724

github-actions · 2022-10-21T17:56:17Z

Chat bundle size is decreased✅.

Current size: 5385698
Base size: 5459488
Diff size: -73790

prprabhu-ms · 2022-10-21T18:52:31Z

How do you feel about holding this PR back until we cut the next stable release branch. It's been a while since the last stable release, and it'd be good to release this in a separate, smaller, stable release, clearly calling out the change.

JamesBurnside · 2022-10-21T22:16:52Z

How do you feel about holding this PR back until we cut the next stable release branch. It's been a while since the last stable release, and it'd be good to release this in a separate, smaller, stable release, clearly calling out the change.

Sure thing!

Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

…to-react

github-actions · 2022-10-21T22:52:17Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ohpcqxqqln.chromatic.com/

prprabhu-ms · 2022-10-24T16:39:29Z

Feel free to merge this when ready. 1.4.0 release branch has been created: https://github.com/Azure/communication-ui-library/tree/release/1.4.0

PorterNan · 2022-10-24T17:24:59Z

    "@storybook/addon-essentials": "~6.5.7",
    "@storybook/addon-links": "~6.5.7",
    "@storybook/addon-storyshots": "~6.5.7",
+    "@storybook/builder-webpack5": "6.5.12",


There are some other packages like @storybook/api are still staying in ~6.5.7, I guess we might want to align them together? (maybe make them all into ~6.5.12?)

We probably should but as there's no errors I imagine it will fall into 'isn't broke won't fix it'. In saying that storybook7 is currently in development and on like alpha v42 so easiest to wait for that then do a big upgrade!

…ions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

…e config screen (#2434) * add drawer to mobile * Change files * add drawer to mobile * Change files * Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * Fix `dtmfDialpadPlaceHolderText` spelling and restrict it to beta builds (#2439) * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * pr fix * pr change * pr change * pr change * pr fix Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>

* add drawer to mobile * Change files * add drawer to mobile * Change files * Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * Fix `dtmfDialpadPlaceHolderText` spelling and restrict it to beta builds (#2439) * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * pr fix * pr change * add modal to config screen * pr change * Cheery-pick to main: Stable release branch hotfix: Fix camera turning back on when turned off on connecting screen (#2458) (#2460) * Revert breaking API change in `CallEndedListener` callback (#2464) * Only export `DeclarativeCallAgent` in beta builds (#2469) * Chat adapter error update (#2471) * add error emitter to typing indicator * add proxy in stateful client for typingIndicator * add test * Change files * fix name * Update @internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json * update composite test script to build first * add test to stateful suite * fix spelling... * remove auto build * 1.4.0 pre-release branch (#2432) * pr change * pr fix * Add webpack 5 support for treeshaking (#2448) * Add webpack 5 support for treeshaking * Remove webpack plugin * Use not deprecated api Co-authored-by: Nan Jiang <jinan@microsoft.com> * pr fix * Change files * build fix Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Porter Nan <jiangnanhello@live.com> Co-authored-by: Nan Jiang <jinan@microsoft.com>

* add drawer to mobile * Change files * add drawer to mobile * Change files * Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * Fix `dtmfDialpadPlaceHolderText` spelling and restrict it to beta builds (#2439) * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * pr fix * pr change * add modal to config screen * test * test * Update packages/react-composites CallComposite browser test snapshots * pr fix * build fix * build fix * pr fix * Change files * pr fix * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…eta.1 (#2548) * Revert "Require webpack 5 in our lib... (#2428)" from release/1.4.1-beta.1

JamesBurnside added 5 commits October 21, 2022 17:18

Update html-to-parser version

d1c359e

Add troubleshooting section for webpack 4

abced26

Update storybook build and documentation

d70f358

Update storybook manager to webpack 5

4ab0af3

change files

6f7cbbc

JamesBurnside assigned PorterNan Oct 21, 2022

JamesBurnside requested review from alkwa-msft, anjulgarg, carocao-msft and dmceachernmsft as code owners October 21, 2022 17:49

JamesBurnside assigned alkwa-msft Oct 21, 2022

JamesBurnside requested review from PorterNan, edwardlee-msft, mgamis-msft, prabhjot-msft and prprabhu-ms as code owners October 21, 2022 17:49

JamesBurnside assigned prprabhu-ms Oct 21, 2022

prprabhu-ms reviewed Oct 21, 2022

View reviewed changes

Comment thread packages/storybook/stories/Troubleshooting.stories.mdx Outdated

prprabhu-ms approved these changes Oct 21, 2022

View reviewed changes

JamesBurnside and others added 2 commits October 21, 2022 15:18

Update packages/storybook/stories/Troubleshooting.stories.mdx

3cb59f6

Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into jaburnsi/update-html-…

45c11a1

…to-react

JamesBurnside force-pushed the jaburnsi/update-html-to-react branch from 1eaadaf to 45c11a1 Compare October 21, 2022 22:46

PorterNan reviewed Oct 24, 2022

View reviewed changes

PorterNan approved these changes Oct 24, 2022

View reviewed changes

JamesBurnside merged commit 7244e8a into main Oct 24, 2022

JamesBurnside deleted the jaburnsi/update-html-to-react branch October 24, 2022 17:29

edwardlee-msft added a commit that referenced this pull request Nov 21, 2022

Revert Require webpack 5 in our lib... (#2428)

0b1f9cf

edwardlee-msft added a commit that referenced this pull request Nov 21, 2022

Revert "Require webpack 5 in our lib... (#2428)" from release/1.4.1-b…

87c6d16

…eta.1 (#2548) * Revert "Require webpack 5 in our lib... (#2428)" from release/1.4.1-beta.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version#2428

Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version#2428
JamesBurnside merged 7 commits intomainfrom
jaburnsi/update-html-to-react

JamesBurnside commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2022 •

edited

Loading

Uh oh!

Uh oh!

prprabhu-ms commented Oct 21, 2022

Uh oh!

JamesBurnside commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022

Uh oh!

prprabhu-ms commented Oct 24, 2022

Uh oh!

PorterNan Oct 24, 2022

Uh oh!

JamesBurnside Oct 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

JamesBurnside commented Oct 21, 2022

What

Why

How Tested

Uh oh!

github-actions Bot commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is decreased✅.

Uh oh!

github-actions Bot commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is decreased✅.

Uh oh!

github-actions Bot commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is decreased✅.

Uh oh!

Uh oh!

prprabhu-ms commented Oct 21, 2022

Uh oh!

JamesBurnside commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022

Uh oh!

prprabhu-ms commented Oct 24, 2022

Uh oh!

PorterNan Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

JamesBurnside Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Oct 21, 2022 •

edited

Loading

github-actions Bot commented Oct 21, 2022 •

edited

Loading

github-actions Bot commented Oct 21, 2022 •

edited

Loading