Skip to content

fix: change fira source#1944

Merged
wusteven815 merged 8 commits intodeephaven:mainfrom
wusteven815:change-fira-source
Apr 26, 2024
Merged

fix: change fira source#1944
wusteven815 merged 8 commits intodeephaven:mainfrom
wusteven815:change-fira-source

Conversation

@wusteven815
Copy link
Copy Markdown
Contributor

@wusteven815 wusteven815 commented Apr 17, 2024 •
edited
Loading

@wusteven815 wusteven815 self-assigned this Apr 17, 2024
@mofojed mofojed requested a review from dsmmcken April 18, 2024 13:41
@mofojed
Copy link
Copy Markdown
Member

mofojed commented Apr 18, 2024

@dsmmcken would these differences be expected/okay? Fonts appear okay to me, tabular numbering etc.

Actual:
typography-actual

Expected:
typography-expected

Diff:
typography-diff

From in the app on a table with numbers:
image

dsmmcken
dsmmcken previously requested changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Fira Mono, which is being substituted. The previous package included both Fira Sans and Mono, you'll have to add those in as well.

That's frustrating that the kerning tables must be different. Still looks acceptable, and has correct font-features-settings. 🤷

@dsmmcken
Copy link
Copy Markdown
Contributor

dsmmcken commented Apr 18, 2024

null

We are probably also missing an italic version in that weight.

@wusteven815 wusteven815 linked an issue Apr 23, 2024 that may be closed by this pull request
Fira fonts require GitHub to install #1902
Closed
@wusteven815 wusteven815 marked this pull request as ready for review April 24, 2024 14:23
@wusteven815 wusteven815 requested review from dsmmcken and mofojed April 24, 2024 15:13
dsmmcken
dsmmcken reviewed Apr 24, 2024
View reviewed changes
Comment thread packages/app-utils/src/components/FontBootstrap.tsx
Comment thread packages/app-utils/src/components/FontBootstrap.tsx
dsmmcken
dsmmcken previously approved these changes Apr 25, 2024
View reviewed changes
mofojed
mofojed previously approved these changes Apr 26, 2024
View reviewed changes
@wusteven815 wusteven815 dismissed stale reviews from mofojed and dsmmcken via a110e7e April 26, 2024 13:22
mofojed
mofojed previously requested changes Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-run npm install to update the package-lock.json now.

@wusteven815 wusteven815 requested review from dsmmcken and mofojed April 26, 2024 14:16
@wusteven815 wusteven815 merged commit 07e5a26 into deephaven:main Apr 26, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 26, 2024
mofojed pushed a commit to deephaven/deephaven-core that referenced this pull request Oct 16, 2025
@github-actions @deephaven-internal
feat(ui): Update web version 1.8.0 (#7326)
3335e8e 
Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v1.8.0
**Features**
- Column organization overflow and undo/redo
(deephaven/web-client-ui#2546)
([5ef19c2](deephaven/web-client-ui@5ef19c2))
- [DH-16956](https://deephaven.atlassian.net/browse/DH-16956): Move
fontbootstrap from app-utils to components so it can be consumed in DHE
(deephaven/web-client-ui#2545)
([c0084cf](deephaven/web-client-ui@c0084cf)),
closes deephaven/web-client-ui#1944
- Upgrade to React 18
(deephaven/web-client-ui#2527)
([b369a51](deephaven/web-client-ui@b369a51))

**Bug Fixes**
- Accept all HasEventHandling types when creating event Promise
(deephaven/web-client-ui#2550)
([e9774ad](deephaven/web-client-ui@e9774ad))
- Add explicit refs to react-transition-group for React 19 support
(deephaven/web-client-ui#2534)
([eaa583e](deephaven/web-client-ui@eaa583e))
- [DH-20255](https://deephaven.atlassian.net/browse/DH-20255) Limit
maximum depth to serialize redux log data
(deephaven/web-client-ui#2544)
([9cd6593](deephaven/web-client-ui@9cd6593))
- [DH-20319](https://deephaven.atlassian.net/browse/DH-20319): Stuck to
bottom of table not sticking
(deephaven/web-client-ui#2547)
([5216008](deephaven/web-client-ui@5216008))
- [DH-20500](https://deephaven.atlassian.net/browse/DH-20500): Links
without operators not working
(deephaven/web-client-ui#2541)
([cbb4fc5](deephaven/web-client-ui@cbb4fc5))
- Pass optional expandDescendants arg to setColumnExpanded
(deephaven/web-client-ui#2540)
([a19bc11](deephaven/web-client-ui@a19bc11))

Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v1.7.0
**Features**
- [DH-19413](https://deephaven.atlassian.net/browse/DH-19413):
Expandable columns support
(deephaven/web-client-ui#2537)
([6938c47](deephaven/web-client-ui@6938c47))

**Bug Fixes**
- [DH-20229](https://deephaven.atlassian.net/browse/DH-20229): Value is
null or undefined when scrolling rollup
(deephaven/web-client-ui#2538)
([7b752ae](deephaven/web-client-ui@7b752ae))



[DH-16956]:
https://deephaven.atlassian.net/browse/DH-16956?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[DH-20255]:
https://deephaven.atlassian.net/browse/DH-20255?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dsmmcken dsmmcken dsmmcken approved these changes

@mofojed mofojed mofojed approved these changes

Assignees

@wusteven815 wusteven815

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fira fonts require GitHub to install

3 participants

@wusteven815 @mofojed @dsmmcken
⚡